Copilot commented on code in PR #10536:
URL: https://github.com/apache/rocketmq/pull/10536#discussion_r3447775520
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageRequestHeader.java:
##########
@@ -246,6 +247,10 @@ public Long getQueueOffset() {
return queueOffset;
}
+ public void setQueueOffset(long queueOffset) {
+ this.queueOffset = queueOffset;
+ }
+
public void setQueueOffset(Long queueOffset) {
this.queueOffset = queueOffset;
}
Review Comment:
`setQueueOffset(Long)` now assigns a boxed `Long` into a primitive `long`
field; passing `null` will throw a NullPointerException due to unboxing. Either
drop the boxed overload or guard against null.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageRequestHeader.java:
##########
@@ -23,6 +23,7 @@
import com.google.common.base.MoreObjects;
import io.netty.buffer.ByteBuf;
import java.util.HashMap;
+import java.util.HashMap;
Review Comment:
Duplicate `HashMap` import is redundant and should be removed to keep the
import list clean.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageResponseHeader.java:
##########
@@ -134,6 +147,10 @@ public Long getSuggestWhichBrokerId() {
return suggestWhichBrokerId;
}
+ public void setSuggestWhichBrokerId(long suggestWhichBrokerId) {
+ this.suggestWhichBrokerId = suggestWhichBrokerId;
+ }
+
public void setSuggestWhichBrokerId(Long suggestWhichBrokerId) {
this.suggestWhichBrokerId = suggestWhichBrokerId;
}
Review Comment:
`setSuggestWhichBrokerId(Long)` now assigns a boxed `Long` into a primitive
`long` field; passing `null` will throw a NullPointerException due to unboxing.
Either drop the boxed overload or guard against null.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageResponseHeader.java:
##########
@@ -22,6 +22,7 @@
import io.netty.buffer.ByteBuf;
import java.util.HashMap;
+import java.util.HashMap;
Review Comment:
Duplicate `HashMap` import is redundant and should be removed to keep the
import list clean.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageRequestHeader.java:
##########
@@ -278,6 +287,10 @@ public Long getSuspendTimeoutMillis() {
return suspendTimeoutMillis;
}
+ public void setSuspendTimeoutMillis(long suspendTimeoutMillis) {
+ this.suspendTimeoutMillis = suspendTimeoutMillis;
+ }
+
public void setSuspendTimeoutMillis(Long suspendTimeoutMillis) {
this.suspendTimeoutMillis = suspendTimeoutMillis;
}
Review Comment:
`setSuspendTimeoutMillis(Long)` now assigns a boxed `Long` into a primitive
`long` field; passing `null` will throw a NullPointerException due to unboxing.
Either drop the boxed overload or guard against null.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageResponseHeader.java:
##########
@@ -118,6 +123,10 @@ public Long getMinOffset() {
return minOffset;
}
+ public void setMinOffset(long minOffset) {
+ this.minOffset = minOffset;
+ }
+
public void setMinOffset(Long minOffset) {
this.minOffset = minOffset;
}
Review Comment:
`setMinOffset(Long)` now assigns a boxed `Long` into a primitive `long`
field; passing `null` will throw a NullPointerException due to unboxing. Either
drop the boxed overload or guard against null.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageRequestHeader.java:
##########
@@ -270,6 +275,10 @@ public Long getCommitOffset() {
return commitOffset;
}
+ public void setCommitOffset(long commitOffset) {
+ this.commitOffset = commitOffset;
+ }
+
public void setCommitOffset(Long commitOffset) {
this.commitOffset = commitOffset;
}
Review Comment:
`setCommitOffset(Long)` now assigns a boxed `Long` into a primitive `long`
field; passing `null` will throw a NullPointerException due to unboxing. Either
drop the boxed overload or guard against null.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageRequestHeader.java:
##########
@@ -294,6 +307,10 @@ public Long getSubVersion() {
return subVersion;
}
+ public void setSubVersion(long subVersion) {
+ this.subVersion = subVersion;
+ }
+
public void setSubVersion(Long subVersion) {
this.subVersion = subVersion;
}
Review Comment:
`setSubVersion(Long)` now assigns a boxed `Long` into a primitive `long`
field; passing `null` will throw a NullPointerException due to unboxing. Either
drop the boxed overload or guard against null.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageResponseHeader.java:
##########
@@ -110,6 +111,10 @@ public Long getNextBeginOffset() {
return nextBeginOffset;
}
+ public void setNextBeginOffset(long nextBeginOffset) {
+ this.nextBeginOffset = nextBeginOffset;
+ }
+
public void setNextBeginOffset(Long nextBeginOffset) {
this.nextBeginOffset = nextBeginOffset;
}
Review Comment:
`setNextBeginOffset(Long)` now assigns a boxed `Long` into a primitive
`long` field; passing `null` will throw a NullPointerException due to unboxing.
Either drop the boxed overload or guard against null.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageResponseHeader.java:
##########
@@ -126,6 +135,10 @@ public Long getMaxOffset() {
return maxOffset;
}
+ public void setMaxOffset(long maxOffset) {
+ this.maxOffset = maxOffset;
+ }
+
public void setMaxOffset(Long maxOffset) {
this.maxOffset = maxOffset;
}
Review Comment:
`setMaxOffset(Long)` now assigns a boxed `Long` into a primitive `long`
field; passing `null` will throw a NullPointerException due to unboxing. Either
drop the boxed overload or guard against null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
