wang-jiahua commented on code in PR #10536:
URL: https://github.com/apache/rocketmq/pull/10536#discussion_r3449641004
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageResponseHeader.java:
##########
@@ -52,10 +52,10 @@ public void checkFields() throws RemotingCommandException {
@Override
public void encode(ByteBuf out) {
- writeIfNotNull(out, "suggestWhichBrokerId", suggestWhichBrokerId);
- writeIfNotNull(out, "nextBeginOffset", nextBeginOffset);
- writeIfNotNull(out, "minOffset", minOffset);
- writeIfNotNull(out, "maxOffset", maxOffset);
+ writeLong(out, "suggestWhichBrokerId", suggestWhichBrokerId);
Review Comment:
@/tmp/r36-t2.txt
##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/header/PullMessageRequestHeader.java:
##########
@@ -47,19 +47,19 @@ public class PullMessageRequestHeader extends
TopicQueueRequestHeader implements
@CFNotNull
private Integer queueId;
@CFNotNull
- private Long queueOffset;
+ private long queueOffset;
Review Comment:
@/tmp/r36-t3.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
