pilichoumao commented on issue #10599: URL: https://github.com/apache/rocketmq/issues/10599#issuecomment-4926996687
I have prepared a RIP-2 Proxy Admin M1 implementation for community review. Review artifacts: - RocketMQ implementation draft PR: https://github.com/apache/rocketmq/pull/10603 - Public API draft PR in `rocketmq-apis`: https://github.com/apache/rocketmq-apis/pull/112 - Implementation fork branch: https://github.com/pilichoumao/rocketmq/tree/rip2-proxy-admin-m1 - API fork branch: https://github.com/pilichoumao/rocketmq-apis/tree/rip2-proxy-admin-public-api Implemented M1 scope: - Public generated `apache.rocketmq.v2.ProxyAdminService` endpoint for `ListClients`, `DescribeClient`, `ListClientsByGroup`, and `ListClientsByTopic`. - Independent Proxy admin gRPC server registration, separated from the data-plane messaging service. - Local online-client read model populated from gRPC client lifecycle events. - Server-side filters for client id, client id prefix, group, topic, client language, connect-time range, `pageNum`, and `pageSize <= 100`. - ACL facade using `proxy.admin.client`: list RPCs use `LIST`, describe uses `GET`. - Dedicated admin query executor, metrics/tracing/logging wrapper, bilingual docs, and 1M synthetic client benchmark report. Current API gate: The RocketMQ implementation draft intentionally depends on local contest artifact `org.apache.rocketmq:rocketmq-proto:2.2.0-rip2-SNAPSHOT`, generated from the companion `rocketmq-apis` proposal branch. It should remain a draft until the community agrees on the public proto ownership, field numbers, generated artifact version, and publication path. Verification evidence: ```text Focused public endpoint/startup tests: Tests run: 36, Failures: 0, Errors: 0, Skipped: 0 BUILD SUCCESS Broad proxy admin verification: Tests run: 707, Failures: 0, Errors: 0, Skipped: 0 BUILD SUCCESS Package smoke: BUILD SUCCESS ``` M1 public endpoint currently accepts omitted scope / `PROXY_SCOPE_LOCAL_PROXY`; `PROXY_SCOPE_ALL_PROXIES` and `PROXY_SCOPE_PROXY_ID` remain gated until multi-proxy discovery, timeout, authorization, and page ownership semantics are finalized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
