itxaiohanglover commented on PR #10645: URL: https://github.com/apache/rocketmq/pull/10645#issuecomment-5035868301
Nice small addition — LMQ count is useful for operators. Two questions: 1. Should this gauge be registered conditionally on `enableLmq` (or the equivalent broker config)? For clusters that never enable LMQ, an always-present `rocketmq_lmq_number 0` series adds cardinality/noise to every scrape without carrying information. 2. Is `messageStore.getQueueStore().getLmqNum()` O(1) (a maintained counter) or does it scan the queue table? The gauge callback runs on every metrics collection, so a scan over a large queue table could get expensive on brokers with many LMQs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
