f1amingo commented on PR #10645: URL: https://github.com/apache/rocketmq/pull/10645#issuecomment-5040975236
Thanks for the thoughtful review! 1. **Conditional registration**: Adopted. The gauge is now gated behind `messageStore.getMessageStoreConfig().isEnableLmq()`, so clusters without LMQ enabled won't emit this series at all. Updated in the latest push. 2. **O(1) confirmed**: `getLmqNum()` simply returns `lmqCounter.get()` — an `AtomicInteger` maintained incrementally on LMQ creation/deletion. No table scan involved, safe for high-frequency collection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
