Aias00 opened a new issue, #10782:
URL: https://github.com/apache/rocketmq/issues/10782

   ### Before Creating the Bug Report
   
   - [x] I found a bug, not just asking a question, which should be created in 
GitHub Issues.
   - [x] I have searched the existing issues and believe this is not a 
duplicate.
   - [x] I have confirmed that this bug belongs to the current repository.
   
   ### Describe the Bug
   
   Proxy remoting lockBatchMQ and unlockBatchMQ return immediately when the 
decoded MessageQueue set is empty, but the response only carries the request 
body and remark. The response code is never set.
   
   Code evidence:
   
   - 
proxy/src/main/java/org/apache/rocketmq/proxy/remoting/activity/ConsumerManagerActivity.java
 handles LOCK_BATCH_MQ.
   - 
proxy/src/main/java/org/apache/rocketmq/proxy/remoting/activity/ConsumerManagerActivity.java
 handles UNLOCK_BATCH_MQ.
   - In both empty mqSet branches, the code sets body and remark MessageQueue 
set is empty, then returns the response without setting a non-success 
ResponseCode.
   
   This makes an invalid request ambiguous to remoting clients and operations 
tooling, because the protocol response does not explicitly signal failure.
   
   ### Expected Behavior
   
   When mqSet is empty, Proxy should return a response with a clear failure 
code and remark instead of returning a response with an unset code.
   
   ### Scope
   
   RocketMQ Studio Track 2 / Proxy Admin and remoting compatibility diagnostics.
   
   ### Proposed Fix
   
   Set an explicit failure code, for example ResponseCode.SYSTEM_ERROR, for 
empty lock/unlock batch MQ requests, and add unit coverage for both paths.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to