RockteMQ-AI commented on issue #10782:
URL: https://github.com/apache/rocketmq/issues/10782#issuecomment-5163823477

   **Issue Evaluation**
   
   Category: `type/bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase 
(`develop@eddb235c1bd8`).
   
   **Root Cause:** When `mqSet` is empty, both `lockBatchMQ` and 
`unlockBatchMQ` create a response via 
`RemotingCommand.createResponseCommand(null)` but never explicitly call 
`response.setCode(...)`. The response is returned with only a remark set, 
relying on the default code from `createResponseCommand(null)`.
   
   **Note:** The issue references `AdminProcessorBase.java`, but the actual 
code is in `ConsumerManagerActivity.java` (lines 137-141 for lock, 155-159 for 
unlock).
   
   **Impact:** Clients receive ambiguous responses for empty queue set 
operations — no explicit success or error code.
   
   **Severity:** low — edge case with empty input, but protocol correctness 
matters.
   
   **File:** 
`proxy/src/main/java/org/apache/rocketmq/proxy/remoting/activity/ConsumerManagerActivity.java`
 (lines 137-141, 155-159)
   
   An automated fix proposal will be generated. Reply `/approve` to proceed 
with PR generation.
   
   ---
   *Automated evaluation by github-manager-bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to