123123213weqw opened a new issue, #1457: URL: https://github.com/apache/rocketmq-dashboard/issues/1457
## Bug `SettingsService.saveGeneralSettings` persists the new general settings and then calls `OperationAuditService.record` directly. If the audit store is temporarily unavailable, the audit exception escapes after the settings were already saved, so the API reports a failure even though the mutation succeeded. This can prompt callers to retry an already-applied update and differs from the best-effort audit pattern used by other mutation services. ## Expected behavior Once general settings are persisted, a secondary audit failure should be logged but must not change the save result. ## Proposed fix - isolate the settings audit call behind a small best-effort helper - log the audit failure with context - add a service regression test proving the repository save returns normally when audit recording throws -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
