RockteMQ-AI commented on issue #1457: URL: https://github.com/apache/rocketmq-dashboard/issues/1457#issuecomment-5237548246
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The `SettingsService.saveGeneralSettings` audit-after-save issue is valid. When the audit service throws after settings are already persisted, the API returns failure for an operation that actually succeeded — causing callers to potentially retry and apply duplicate updates. **Root Cause:** `OperationAuditService.record` is called synchronously after persist; its exception escapes and overrides the successful save result. **Impact:** False failure responses may trigger unnecessary retries; inconsistent with best-effort audit pattern used elsewhere. **Severity:** Medium — can cause confusing API responses and retry storms. A fix PR is available: #1458 (`agent/isolate-settings-audit`). --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
