RockteMQ-AI commented on issue #10899: URL: https://github.com/apache/rocketmq/issues/10899#issuecomment-5242155782
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase on the `develop` branch. **Root Cause:** When `popConsumerKVServiceEnable=true`, `PopMessageProcessor` branches to `PopConsumerService.popAsync()` (line ~380). This KV POP path handles message delivery and acknowledgment but never calls `BrokerStatsManager.incBrokerGetNums()`, `incGroupGetNums()`, or `incGroupGetSize()`. The only stats calls in `PopConsumerService` are for **PUT** operations (line ~752-756, `incBrokerPutNums`/`incTopicPutNums`/`incTopicPutSize`). In contrast, the regular POP path in `PopMessageProcessor` (line ~792-795) correctly updates all three GET metrics after successful message delivery. **Impact:** `mqadmin consumerProgress` reports Consume TPS as 0; `BROKER_GET_NUMS`, `GROUP_GET_NUMS`, `GROUP_GET_SIZE`, and the corresponding OTel metrics (`rocketmq_messages_out_total`, `rocketmq_throughput_out_total`) are not updated for KV POP consumption. **Severity:** Medium — data plane works correctly (messages are consumed and acked), but observability is broken. **Suggested Fix:** Add `incBrokerGetNums`/`incGroupGetNums`/`incGroupGetSize` calls in the KV POP success path, either inside `PopConsumerService.popAsync()` after messages are found, or in `PopMessageProcessor` after the `popAsyncFuture` completes with `result.isFound()`. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
