RockteMQ-AI commented on issue #10899:
URL: https://github.com/apache/rocketmq/issues/10899#issuecomment-5267906204

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** In `PopMessageProcessor.java`, when 
`popConsumerKVServiceEnable=true` (line 380), the code takes an async path via 
`popConsumerService().popAsync()`. The result is processed in a `thenApply` 
callback that handles the response but does not call any stats methods 
(`incBrokerGetNums`, `incGroupGetNums`, etc.).
   
   In contrast, the traditional POP path (line 792) correctly calls 
`incBrokerGetNums(topic, result.getMessageCount())`. The KV POP path is missing 
these metric updates entirely.
   
   **Impact:** When KV POP is enabled:
   - `mqadmin consumerProgress` reports Consume TPS as 0
   - `BROKER_GET_NUMS`, `GROUP_GET_NUMS`, `GROUP_GET_SIZE` are not updated
   - OTel metrics `rocketmq_messages_out_total` and 
`rocketmq_throughput_out_total` are inaccurate
   
   **Severity:** Medium — monitoring and observability are broken for KV POP 
mode.
   
   **Suggested Fix:** Add the same stats increment calls in the KV POP 
`thenApply` callback that exist in the traditional POP path (around line 792).
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with 
PR generation.
   
   ---
   *Automated evaluation by github-manager*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to