tju-yxq commented on PR #2676: URL: https://github.com/apache/rocketmq-dashboard/pull/2676#issuecomment-5450806702
The implementation for #2675 is pushed as `a5f92f7f52c770beaf6c3d706c9bdbd125636e77`. Review points: - Provider lookup, region discovery, per-region listing, and per-instance creation now have explicit runtime-failure boundaries; `BusinessException` duplicate-name skips and validation behavior remain unchanged. - Null/malformed rows and duplicate region+instance rows are handled without duplicate detail/persistence calls. - `CloudImportResultVO` keeps the failure detail list bounded while exposing the complete `failedCount` and `failureDetailsTruncated` state; the frontend uses those fields and no longer reports a failed zero-import as "all instances already exist". Local validation passed: focused `InstanceServiceTest` (75), full Maven suite (1,794 tests, 0 failures/errors/skips, Checkstyle 0), focused Vitest tests (29), TypeScript, ESLint (0 errors), Prettier, Vite build, and `git diff --check`. No GitHub checks are reported yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
