tju-yxq commented on PR #2676:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2676#issuecomment-5455195581
Follow-up for the review suggestion in commit
`398086117719f84db8b1f1e6363cb916e6f069fb`:
- Added `DuplicateInstanceNameException`, a typed `BusinessException` for
name conflicts.
- `requireUniqueInstanceName()` now raises that exception directly.
- Cloud import now catches the typed exception explicitly and counts it as
`skipped`; other `BusinessException` instances are always reported as failures
instead of being classified from their message text.
- This removes the fragile `getMessage().startsWith("Instance name already
exists")` contract without changing the user-facing error text or HTTP code.
Verification:
- `mvn -q '-Dtest=InstanceServiceTest,InstanceControllerTest' test` passed.
- `mvn -DskipTests=false test` passed: 1,795 tests, 0 failures, 0 errors, 0
skipped; Checkstyle 0 violations.
- `git diff --check` passed.
The failure-detail limits remain fixed safety bounds rather than deployment
configuration; no configuration surface was added for the non-blocking
suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
