lwclover commented on code in PR #10891:
URL: https://github.com/apache/rocketmq/pull/10891#discussion_r3919999441
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/client/ClientActivity.java:
##########
@@ -146,7 +146,7 @@ public CompletableFuture<NotifyClientTerminationResponse>
notifyClientTerminatio
try {
String clientId = ctx.getClientID();
- LanguageCode languageCode =
LanguageCode.valueOf(ctx.getLanguage());
Review Comment:
Could you clarify when `ctx.getLanguage()` can be empty or contain an
invalid value?
Since `LanguageCode.valueOf(ctx.getLanguage())` will throw an exception if
the value is `null`, empty, or not a valid enum constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
