Aias00 commented on code in PR #10891:
URL: https://github.com/apache/rocketmq/pull/10891#discussion_r3920362340
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/client/ClientActivity.java:
##########
@@ -146,7 +146,7 @@ public CompletableFuture<NotifyClientTerminationResponse>
notifyClientTerminatio
try {
String clientId = ctx.getClientID();
- LanguageCode languageCode =
LanguageCode.valueOf(ctx.getLanguage());
Review Comment:
x-mq-language is client-controlled metadata.
ContextInitPipeline#getDefaultStringMetadataInfo converts a missing header to
an empty string, while an arbitrary value is copied unchanged into
ProxyContext. Both
values later reach LanguageCode.valueOf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
