Copilot commented on code in PR #4633:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4633#discussion_r4058027977
##########
web/src/pages/instance/message.tsx:
##########
@@ -221,7 +224,7 @@ const TraceDiagnosticsPanel = ({ diagnostics }: {
diagnostics: MessageTraceDiagn
type={diagnostics.statusColor}
message={
<Flex gap={8} align="center" wrap>
- <span>轨迹诊断</span>
+ <span>{t('messagePage.traceDiagnostics')}</span>
Review Comment:
English mode still exposes Chinese trace-diagnostic text in this panel:
`diagnostics.statusText`, each issue's `title`/`description`, and
`recommendations` come from `analyzeMessageTrace`, whose status, issue, and
recommendation literals are hard-coded Chinese in
`utils/messageTraceDiagnostics.ts`. Translating only the heading and column
labels leaves the main status and diagnostic details untranslated. Return
diagnostic codes/parameters and translate them here, or make the utility
language-aware.
##########
web/src/i18n/translations.ts:
##########
@@ -504,6 +504,131 @@ const translations: Record<string, Record<Lang, string>>
= {
'acl.title': { zh: 'ACL 管理', en: 'ACL Management' },
'message.title': { zh: '消息查询', en: 'Message Search' },
+ // ─── Message Page ───
+ 'messagePage.subtitle': {
+ zh: '按 Topic、Key 或 Message ID 检索消息',
+ en: 'Search messages by Topic, Key, or Message ID',
Review Comment:
The new catalog entries are only exercised through the existing
default-Chinese page assertions; no MessagePage test switches `LangProvider` to
English and checks these keys, interpolation, or the trace/error fallbacks. An
incorrect or missing English value would therefore pass the suite even though
English localization is the purpose of this PR. Add at least one English-render
test covering the query controls and trace diagnostics/fallbacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
