Frun1na commented on code in PR #4633:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4633#discussion_r4058362198
##########
web/src/pages/instance/message.tsx:
##########
@@ -221,7 +224,7 @@ const TraceDiagnosticsPanel = ({ diagnostics }: {
diagnostics: MessageTraceDiagn
type={diagnostics.statusColor}
message={
<Flex gap={8} align="center" wrap>
- <span>轨迹诊断</span>
+ <span>{t('messagePage.traceDiagnostics')}</span>
Review Comment:
Fixed in 1634995c: `analyzeMessageTrace` now emits catalog keys with
interpolation params (`statusKey`, `titleKey`/`descriptionKey` + `params`,
`recommendationCodes`) instead of Chinese literals, and the panel translates
them, so the status, issue details and recommendations all follow the active
language. Analysis logic is unchanged and Chinese values are byte-identical; an
English-render test now covers the panel.
##########
web/src/i18n/translations.ts:
##########
@@ -504,6 +504,131 @@ const translations: Record<string, Record<Lang, string>>
= {
'acl.title': { zh: 'ACL 管理', en: 'ACL Management' },
'message.title': { zh: '消息查询', en: 'Message Search' },
+ // ─── Message Page ───
+ 'messagePage.subtitle': {
+ zh: '按 Topic、Key 或 Message ID 检索消息',
+ en: 'Search messages by Topic, Key, or Message ID',
Review Comment:
Added in 1634995c: an English-render case (`renders trace diagnostics in
English when the UI language is English`) in `MessagePage.test.tsx` asserts the
panel heading, the delivery status, an issue title and an English
recommendation, so a wrong or missing English value now fails the suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
