Aias00 commented on PR #4455:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4455#issuecomment-5769075847

   Rebased the reviewed implementation onto current `rocketmq-studio@4c697f07a` 
in `3bcc0f4d4` / `670459b6` and changed the PR base to `rocketmq-studio`.
   
   Conflict resolution details:
   
   1. `MessageService` keeps the trunk audit behavior from #4607 and adds the 
`DIRECT_MESSAGE_CONSUME` capability gate before provider dispatch. Unsupported 
capability and provider/business failures are audited as FAILED; audit-write 
failures remain isolated.
   2. `MessageServiceTest` keeps the trunk SUCCESS/non-success/exception audit 
regressions and adds the unsupported-capability regression.
   3. `message.tsx` keeps the trunk localization and async-state fixes while 
retaining the reviewed always-visible action, server-driven capability state, 
localized disabled tooltip, and guarded modal.
   4. A post-rebase review found that newly created mock instances lost 
capabilities after removing the production frontend capability table. 
`670459b6` now derives mock-only capabilities from vendor and adds 
Apache/Tencent creation coverage.
   5. Both commits now carry DCO sign-offs.
   
   Verification on the rebased tree: focused backend 123/123; full backend 3151 
passed with 3 skipped; focused frontend 44/44; full frontend 1284/1284; 
frontend build, lint (0 errors), Prettier, Maven package, Checkstyle, and `git 
diff --check` passed. Independent re-review found no remaining issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to