Frun1na opened a new pull request, #4820:
URL: https://github.com/apache/rocketmq-dashboard/pull/4820
### Which Issue(s) This PR Fixes
- Fixes #ISSUE_ID
### Brief Description
Section 14 (settings) omitted most of the fields the endpoints actually
accept and return. Every
correction was read back from `GeneralSettingsVO`,
`GeneralSettingsUpdateDTO`, `DataSourceDTO`,
`DataSourceTestDTO` and `SettingsController`:
- 14.1 `GET /api/settings/general`: the response table listed 10 of the ~19
serialized fields. Added
`llmEngine`, `deploymentName`, `apiVersion`, `awsRegion`, `maxTokens`,
`temperature`,
`dingtalkWebhook`, `dingtalkWebhookConfigured`,
`dingtalkSigningSecretConfigured`, `emailRecipients`,
`smsWebhook` and `smsWebhookConfigured` — including the three `READ_ONLY`
`*Configured` booleans the
VO exposes via `@JsonProperty` (secrets themselves are `WRITE_ONLY` and
stay out of the response).
- 14.2 `POST /api/settings/general/save`: the request table now lists
`llmEngine`, `deploymentName`,
`apiVersion`, `awsRegion`, `dingtalkWebhook`, `dingtalkSigningSecret` and
`clearDingtalkSigningSecret`, `emailRecipients` and `smsWebhook`
(`GeneralSettingsUpdateDTO:50-66`).
Note `maxTokens` / `temperature` are deliberately absent from the request
DTO — they appear in the
response only.
- 14.5 / 14.6 data source create & update: added the optional `instanceIds`
field
(`DataSourceDTO:48`, `List<@NotBlank String>`).
- 14.8 data source test: added `username`, `password` and `bearerToken`
(`DataSourceTestDTO:35-40`),
the Basic-Auth and Bearer variants of the documented `auth` field.
- New 14.9: `POST /api/settings/general/test-notification?channel=...`
existed in the controller
(`SettingsController:52-55`, channel must be `dingtalk` / `email` / `sms`
per
`NotificationOutboxService:154`) but was missing from the document
entirely.
### How Did You Test This Change
Documentation-only change; there is no docs build or spec validation to run.
Every claim above was
verified by reading the controller mapping and the DTO/VO field declarations
directly (files cited).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
