Frun1na opened a new issue, #4821:
URL: https://github.com/apache/rocketmq-dashboard/issues/4821

   ### Before Creating the Bug Report
   
   - [x] I have searched the [open 
issues](https://github.com/apache/rocketmq-dashboard/issues) and found no 
similar issue.
   
   ### What Happened
   
   `docs/api-spec.md` section 14 (settings) lists only a subset of the fields 
the endpoints accept and
   return:
   
   - `GET /api/settings/general` returns ~19 serialized fields but the document 
lists 10 — among the
     missing ones are `llmEngine`, the Azure/Bedrock fields (`deploymentName`, 
`apiVersion`, `awsRegion`),
     notification channels (`dingtalkWebhook`, `emailRecipients`, `smsWebhook`) 
and the three `READ_ONLY`
     `*Configured` booleans exposed by `GeneralSettingsVO`.
   - `POST /api/settings/general/save` accepts `llmEngine`, `deploymentName`, 
`apiVersion`, `awsRegion`,
     `dingtalkWebhook`, `dingtalkSigningSecret`, `clearDingtalkSigningSecret`, 
`emailRecipients` and
     `smsWebhook` — none of them documented.
   - Data source create/update accept `instanceIds`; the connection test 
accepts `username`, `password`
     and `bearerToken` — all undocumented.
   - `POST /api/settings/general/test-notification` exists in the controller 
but is missing from the
     document entirely.
   
   Integrators and users of the API cannot discover the LLM provider options or 
notification channels
   from the document, and the undocumented fields are invisible to every 
consumer built from it.
   
   ### Expected Behavior
   
   Section 14 should list every accepted request field with its requiredness 
from the validation
   annotations, every serialized response field (marking the `WRITE_ONLY` 
secrets as absent), and include
   the test-notification endpoint.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to