X-LightYear opened a new pull request, #5046: URL: https://github.com/apache/rocketmq-dashboard/pull/5046
## Summary - preserve per-item results when one Topic or Consumer Group import row is invalid - keep valid rows executing while reporting row-level validation failures - retain batch envelope validation and the existing maximum batch size ## Problem The Topic and Consumer Group import services already return `imported`, `failed`, and indexed `failures`, and continue after provider failures. However, nested `@Valid` validation on the REST import DTOs rejected the entire request before the service could process a batch containing one invalid row. ## Fix Remove fail-fast nested validation from the two batch envelopes and validate each row inside the existing service loop. Name and non-negative numeric constraints are preserved as per-item failures. Empty/oversized batches remain envelope errors. ## Behavior For a batch with one valid row and one invalid row, the response now reports the successful item and the indexed failure, while the invalid item never reaches its provider. ## Testing - focused Topic/Consumer Group controller and MetadataService tests: 95 passed - Checkstyle: passed - package with the environment-specific Python license gate skipped: passed - full backend test command: 3198 tests, 7 failures and 27 errors caused by the local MySQL root authentication/integration environment; all relevant import tests passed Fixes #5044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
