zmuxuny opened a new pull request, #5048: URL: https://github.com/apache/rocketmq-dashboard/pull/5048
### Which Issue(s) This PR Fixes - Fixes #5045. ### Brief Description A failed Notification Deliveries list request left the previous rows and total in place after loading ended. After changing filters, a FAILED delivery from the old result set could appear under the new filter and still expose its retry action. On list failure, clear those rows, total and open detail, and show a persistent error with a retry button. While a replacement page is loading, disable actions on its previous rows. Changing filters also closes the old detail drawer. The retry uses the current filters. ### How Did You Test This Change? - Added a regression that first failed on the original code because `Broker disk usage` remained visible after the `DELIVERED` request failed. It also checks that old retry actions are disabled while the request is pending, absent after failure, and that retry reloads the `DELIVERED` filter. - `cd web && npx vitest run src/pages/ops/__tests__/NotificationDeliveriesPage.test.tsx --reporter=dot` — 5/5 passed. - `cd web && npx tsc -b` — passed. - `cd web && npx eslint src/pages/ops/notificationDeliveries.tsx src/pages/ops/__tests__/NotificationDeliveriesPage.test.tsx` — passed. - `cd web && npx vite build` — passed. The separate `npm run license:check` gate still has the existing final-artifact issue tracked by #5019. - Browser review: the error state fits at 768, 1280 and 1440px on this branch. At 375px the target branch's existing fixed sidebar squeezes the page; with the pending layout fix #5025 applied in a temporary review worktree, the error and retry control fit at 375px without page overflow. No #5025 changes are included here. - `git diff --check` — passed. ### Checklist - [x] One coherent list-failure fix; unrelated changes are not bundled in - [x] Conventional commit subject - [x] Regression test added - [x] Existing translated UI strings reused - [x] No new source files or API changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
