Frun1na opened a new pull request, #5075:
URL: https://github.com/apache/rocketmq-dashboard/pull/5075
### Which Issue(s) This PR Fixes
- Fixes #<issue-id>
### Brief Description
The NameServer tab of the broker-cluster topology page renders a
"Connections" column whose value is hardcoded to `0` in `mapClusters` —
`NameServerInfo` (the server contract) carries only `addr` and `status`, so no
connection count exists to show. Every NameServer is displayed as "Connections:
0", which reads like a real measurement of zero client connections.
This drops the fabricated field and its table column and CSV export column.
The proxy tab keeps its connections column, where the value is real
(`ProxyInfo.connections`).
### How Did You Test This Change?
```
cd web && npx vitest run src/pages/studio/__tests__/BrokerCluster.test.tsx
✓ src/pages/studio/__tests__/BrokerCluster.test.tsx (16 tests) 2872ms
Test Files 1 passed (1)
Tests 16 passed (16)
```
The new test fails on the unpatched page (the fabricated column is rendered):
```
× does not fabricate a connections column for NameServers
Tests 1 failed | 15 skipped (16)
```
`npx eslint` on the two touched files reports no issues; `tsc -b && vite
build` passes.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`feat:` / `fix:` /
`refactor:` / `chore:` / `docs:` / `perf:`)
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
- [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [x] New source files carry the ASF license header
- [ ] Documentation touched where behaviour changed (README / `docs/` /
in-app help)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
