Frun1na opened a new pull request, #5077:
URL: https://github.com/apache/rocketmq-dashboard/pull/5077

   ### Which Issue(s) This PR Fixes
   
   - Fixes #<issue-id>
   
   ### Brief Description
   
   `NotificationOutboxService.sendTestMessage` builds the test alert with a 
hardcoded description `"DingTalk notification configuration is working."` 
regardless of the channel being tested. When an operator tests the **email** or 
**sms** channel, the notification that arrives still says "DingTalk 
notification configuration is working." — wrong copy in the very message whose 
job is to confirm the channel works.
   
   The description is now picked per channel (DingTalk / Email / SMS), so the 
test notification names the channel it exercises.
   
   ### How Did You Test This Change?
   
   ```
   cd server && mvn -B -ntp test -Dtest=NotificationOutboxServiceTest
   
   Tests run: 27, Failures: 0, Errors: 0, Skipped: 0
   ```
   
   The new test asserts the sms test webhook payload contains "SMS notification 
configuration is working." and does not contain "DingTalk"; it fails on the 
unpatched service:
   
   ```
   [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0
   ```
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / 
`refactor:` / `chore:` / `docs:` / `perf:`)
   - [x] Tests added or updated for non-trivial changes, test methods named 
`...Test`
   - [x] New UI text has both Chinese and English entries under `web/src/i18n/`
   - [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit 
checks)
   - [x] New source files carry the ASF license header
   - [ ] Documentation touched where behaviour changed (README / `docs/` / 
in-app help)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to