lizhimins commented on PR #4769: URL: https://github.com/apache/rocketmq-dashboard/pull/4769#issuecomment-5812253143
Thanks for the careful contract work here, but we are going to close this one on scope grounds: the coverage gap it targets does not exist for the consumer side, and the tool itself was removed from the catalog by an earlier deliberate decision. 1. `rmq.group.detail` already returns the online client connections of a group: its `instances[]` block carries `clientId`, `protocol` (gRPC/Remoting/UNKNOWN), `address`, `subscribedTopics`, `lastHeartbeat` and per-topic lag (`tool-catalog/tools/group.yaml:165-190`). So an MCP/CLI operator diagnosing "who is connected to this group" can already reach that data; `rmq.client.list` restates it with less context (no lag, no subscriptions per group). 2. The client domain was intentionally deleted when the tool surface was converged (`rmq.client.list` / `rmq.client.describe` removed, client domain 2→0), with the recorded rationale that consumer connections are carried by `group.detail` and producer-side client listing was not offered. The design text quoted in the PR description is the pre-deletion version of that document. Re-adding the tool reverses that decision without addressing it. 3. Practically, the branch also cannot take this as-is: `rmqctl/internal/catalog/catalog_gen.go` conflicts with the current digest (`30a907ad…` on trunk vs `9969cd29…` here, both derived from the older `94c2164d…`), so it would need a rebase plus `make catalog-generate` / `make catalog-verify`. The genuinely uncovered slice is producer-side connections (producer groups and `CLIENT_INNER_PRODUCER` rows), which the Studio backend does serve via `ProducerConnectionService`. If you want to propose something there, please open it as a narrowly scoped tool over that service — ideally after we confirm the tool-surface convergence is being reopened — rather than reinstating the whole client domain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
