Aias00 commented on PR #4956: URL: https://github.com/apache/rocketmq-dashboard/pull/4956#issuecomment-5846533780
Addressed all four items from review `5325649809` in `a00ae4021`. 1. Added descendant-before-root regressions for the shared `CliAgentProvider` timeout and output-limit paths. The provider now has behavior-preserving `startProcess()` and `completionTimeoutSeconds()` seams so those paths are deterministic in tests. 2. Added a Claude `IOException` regression by forcing the no-`/dev/null` fallback and making stdin close fail; it asserts descendant then root termination. 3. Renamed the interruption test to `streamInterruptionDestroysTheProcessTreeTest`. 4. Threaded termination context through `AgentProcessTree.descendants`; `AgentRunHandle` now logs enumeration failures with `agent run <runId>`, restoring the lost attribution. Provider cleanup uses the CLI binary as its context. Verification after the commit: - focused provider/run-handle tests: 40 passed - complete AI backend test set: 925 passed, 3 skipped - `mvn -DskipTests package`: passed - Checkstyle and `git diff --check`: passed - independent follow-up review: approved with no findings @lizhimins please re-review the updated commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
