Aias00 commented on PR #4956: URL: https://github.com/apache/rocketmq-dashboard/pull/4956#issuecomment-5846581735
Follow-up after the base advanced: rebased the branch onto current `origin/rocketmq-studio` (`4ee173ad7`) and force-pushed with lease. The only conflict was in `CliAgentProviderTest`; I retained both the upstream CLI binary-name safety tests and this PR's process-tree helper/regressions. The review follow-up commit is now `012448ae6` (rebased equivalent of `a00ae4021`). Fresh post-rebase verification: - focused provider/run-handle tests: 43 passed - complete AI backend test set: 938 passed, 3 skipped - Checkstyle and `git diff --check`: passed - `mvn -DskipTests package` compiles and repackages successfully, then the latest base's binary-license gate fails; an untouched `origin/rocketmq-studio` worktree reproduces the identical dependency-license failures The PR is mergeable again. @lizhimins please re-review the rebased commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
