Loyal-Young opened a new pull request, #11265:
URL: https://github.com/apache/rocketmq/pull/11265

   ### Which Issue(s) This PR Fixes
   
   - Fixes #11264.
   
   ### Brief Description
   
   ConsistentHashRouter's default hash function shares one mutable 
MessageDigest across routeNode callers. Concurrent routing on an otherwise 
immutable ring can return different nodes for the same key or throw inside the 
digest implementation.
   
   Synchronize the default hash operation. This does not add concurrent 
add/remove support or change the hash algorithm or ring layout.
   
   Reproduction: Route a stable key from eight callers against a fixed ring and 
compare every result with the sequential result.
   
   This is an independent bug fix based on develop 
`78b96bc5e21216cd7896efae08f90c5cde4cae53`, not stacked on the other 
contributions. It changes one implementation and adds one regression test file; 
no new protocol or public API is introduced.
   
   ### How Did You Test This Change?
   
   - The bug-specific regression fails against the unmodified implementation.
   - On this independent branch, JDK 8 / Maven 3.9.9: 
`ConsistentHashRouterConcurrencyTest` — 1 tests passed, zero 
failures/errors/skips.
   - Command: `mvn -pl common -am -Dspotbugs.skip=true -Djacoco.skip=true 
-Dsurefire.failIfNoSpecifiedTests=false 
-Dtest=ConsistentHashRouterConcurrencyTest test`.
   - The combined candidate changes also pass the complete common-module suite: 
284 tests, zero failures/errors/skips.
   - Maven Checkstyle passed; `git diff --check` passed. Local runs disable 
JaCoCo and SpotBugs; this does not claim that upstream GitHub Actions have run 
or passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to