Loyal-Young opened a new pull request, #11263: URL: https://github.com/apache/rocketmq/pull/11263
### Which Issue(s) This PR Fixes - Fixes #11262. ### Brief Description HttpTinyClient.httpGet always appends a '?' when parameters are provided, even if the URL already has a query or a fragment. Empty parameter lists can corrupt an existing query, and parameter names are not form-encoded. Append nonempty parameters with the appropriate separator before the fragment and encode both names and values. Reproduction: Request a local HTTP server with '?fixed=1#fragment' and an additional key/value pair; the server should receive 'fixed=1&key=value'. This is an independent bug fix based on develop `78b96bc5e21216cd7896efae08f90c5cde4cae53`, not stacked on the other contributions. It changes one implementation and adds one regression test file; no new protocol or public API is introduced. ### How Did You Test This Change? - The bug-specific regression fails against the unmodified implementation. - On this independent branch, JDK 8 / Maven 3.9.9: `HttpTinyClientQueryTest` — 3 tests passed, zero failures/errors/skips. - Command: `mvn -pl common -am -Dspotbugs.skip=true -Djacoco.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=HttpTinyClientQueryTest test`. - The combined candidate changes also pass the complete common-module suite: 284 tests, zero failures/errors/skips. - Maven Checkstyle passed; `git diff --check` passed. Local runs disable JaCoCo and SpotBugs; this does not claim that upstream GitHub Actions have run or passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
