chennaji9 opened a new pull request, #5206:
URL: https://github.com/apache/rocketmq-dashboard/pull/5206
### Which Issue(s) This PR Fixes
None — small self-contained fix found by inspection (no issue tracked).
### Brief Description
`deploy/deploy.sh` packs only `server web deploy rmqctl` into the source
archive, but the remote server image build runs `docker build -f
server/Dockerfile` with the repository root as its context, and that
Dockerfile's rmqctl-build stage contains `COPY LICENSE NOTICE /src/`
(server/Dockerfile). On a fresh remote directory the image build therefore
fails at the COPY step, because the two root files were never uploaded. This
adds `LICENSE NOTICE` to the archive so the packaged inputs match what the
Dockerfile consumes, and documents why in the adjacent comment.
Base is `rocketmq-studio` per CONTRIBUTING.md (the PR template's base
comment is outdated).
### How Did You Test This Change?
- `bash -n deploy/deploy.sh` — passes (syntax check).
- Replayed the exact `tar` command from the repo root (with
`web/node_modules` present after `npm ci`):
- `tar tzf` lists `LICENSE` and `NOTICE` at the archive root;
- the archive contains no `web/node_modules`, `web/dist`, `server/target`,
`deploy/.env` or `rmqctl/bin` entries (excludes still hold).
- No remote deployment was executed (would require a real SSH target); the
change only widens the archive input list.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`fix:`)
- [ ] Tests added or updated for non-trivial changes (deploy shell script
has no test harness in this repo; verified via syntax check and archive-content
replay above)
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
(n/a — no UI change)
- [x] Architecture constraints stay green (n/a — no Java change)
- [x] New source files carry the ASF license header (n/a — no new source
file)
- [x] Documentation touched where behaviour changed (comment updated in
place)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
