The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/yy-http-private-dns 
has failed.
Run started by GitHub user yyqdbngt (triggered by yyqdbngt).

Head commit for run:
46c5e9de7f5f6969ae219e09ad949164a4ffaa44 / yyqdbngt <[email protected]>
fix(rmqctl): allow plain HTTP for private-resolving intranet names

isPrivateHost in internal/studio/auth.go only understood literal addresses:
net.ParseIP fails for a hostname, so a Studio endpoint addressed by an
intranet DNS name (http://studio.internal:6789) was rejected with "studio
server must use HTTPS" even though the name resolves exclusively to
loopback/RFC1918/link-local addresses.

isPrivateHost now looks a non-literal host up through net.DefaultResolver
(bounded by a 2s timeout) and accepts it only when every address it resolves
to is private; mixed, public-only and unresolvable names keep requiring HTTPS.

Test: internal/studio/auth_hostname_test.go answers lookups from a table
through an in-process DNS server, so the policy is covered without touching
the machine's real intranet DNS: private-resolving names are accepted by
Target.validate() for plain HTTP, mixed/public/unresolvable names are not.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/36962102453

With regards,
GitHub Actions via GitBox

Reply via email to