Loyal-Young opened a new pull request, #5384: URL: https://github.com/apache/rocketmq-dashboard/pull/5384
### Which Issue(s) This PR Fixes - Fixes #5383 ### Brief Description The notification settings actions now share a synchronous in-flight guard. Starting a test, saving notification fields, or clearing the DingTalk signing secret blocks the other notification actions until completion. Their buttons reflect that state, and a form validation error stays on the form without a misleading test-request failure toast. ### Verification - On the original code, the regression sends two `saveGeneralSettings` requests after starting a DingTalk test and clicking Test email before the first save finishes. - `cd web && node node_modules/vitest/vitest.mjs run src/pages/settings/__tests__/GeneralSettingsTab.test.tsx --pool=threads --maxWorkers=1 --reporter=dot` — 8 tests passed. - `cd web && node node_modules/eslint/bin/eslint.js src/pages/settings/GeneralSettingsTab.tsx src/pages/settings/__tests__/GeneralSettingsTab.test.tsx` — passed. - `cd web && node node_modules/typescript/bin/tsc -p tsconfig.app.json --noEmit --pretty false` — passed. - `git diff --check` — passed. ### AI Assistance AI assistance helped inspect the notification save and test flow and draft the overlapping-action regression. I reproduced the duplicate save on the original code, reviewed the guard and disabled states, and ran the checks above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
