The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/rmqctl-windows-version has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
d475d63cf70c346ddc65a224232440de537bb867 / unbridled-41 
<[email protected]>
fix(rmqctl): default the Windows build to the CLI's declared version

scripts/build-windows.ps1 injected its own default version, and it had
drifted: the script still said 1.0.0 while the Makefile declares
VERSION ?= 3.0.0 and cmd.CLIVersion is "3.0.0". A binary built with the
documented Windows path therefore reported "rmqctl: 1.0.0" - a version no
other build produces - while the script's own header claims it mirrors the
Makefile LDFLAGS.

Align the default and pin the three entry points together with a test that
reads both files, so a future release bump has to update all of them.

Tested: go test ./cmd/ -run TestVersionMetadataAgreesAcrossBuildEntryPoints
(red before: `build-windows.ps1 default = "1.0.0" but cmd.CLIVersion =
"3.0.0"`; green after), go vet ./cmd/ clean, full `go test ./...` pass.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37089151412

With regards,
GitHub Actions via GitBox

Reply via email to