tju-yxq opened a new pull request, #5513:
URL: https://github.com/apache/rocketmq-dashboard/pull/5513
### Which Issue(s) This PR Fixes
- Fixes #5512
### Brief Description
Localizes the DLQ page's remaining hardcoded Chinese strings and adds the
corresponding `dlq.*` keys (zh text unchanged, new English translations) to
`translations.ts`:
- **Table columns & buttons**: `groupName`, `deadLetterCount`,
`lastEnqueueTime`, `retryCount`, `enqueueTime`, `viewMessages`,
`retryMessages`, `resend`, `exportAll`, `exportSelected`, `batchResendSelected`
— the plain export button reuses the existing `common.export` key
- **Retry modal**: `retryModalTitle`, `retryWarning`, `sourceGroup`,
`targetTopic`, `retryTimeRange`, `messageCountWithUnit`, `confirmRetry`,
`retryTargetRequired`, `retryTargetPlaceholder`
- **Detail drawer**: `detailTitle`, `detailTitleWithGroup`,
`detailRangeDescription`, `properties`, `value`, `noProperties`,
`noUserProperties`, `propertiesTruncated`
- **Toasts with interpolation**: `retryScanIncomplete`, `retryCompleted`,
`resendCompleted`, `exportedGroup`, `exportedAll`, `exportedSelected`,
`exportIncompleteWarning`, the load/detail/resend/export failure defaults, and
the two pagination totals
The zh text is byte-identical to what was hardcoded, so Chinese-locale users
see no change; English-locale users get a fully English page. Interpolated
messages use the existing `{param}` convention of `t()`.
### Verification
- `npx vitest run src/pages/instance/__tests__/DLQPage.test.tsx` — 26/26
pass (the suite asserts behavior, not these strings)
- `npx eslint src/pages/instance/dlq.tsx src/i18n/translations.ts` — 0
errors (2 warnings: the pre-existing `react-refresh/only-export-components` on
`formatDateTime`, and one `react-hooks/exhaustive-deps` on `t`, the same class
the other localized pages carry)
- `npx tsc --noEmit` — clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
