123123213weqw opened a new pull request, #5731:
URL: https://github.com/apache/rocketmq-dashboard/pull/5731

   ## Problem / Evidence
   
   The server records these audit operations, but the frontend presentation 
registry (`web/src/pages/ops/auditPresentation.ts`) has no entry for any of 
them:
   
   - `CREATE_ALERT_SILENCE` / `DELETE_ALERT_SILENCE` (`AlertSilenceService`, 
resource `ALERT_SILENCE`)
   - `DELIVER_ALERT_NOTIFICATION`, `RETRY_ALERT_NOTIFICATION`, 
`RETRY_ALERT_NOTIFICATION_MANUALLY`, `FAIL_ALERT_NOTIFICATION` 
(`NotificationOutboxService`, resource `ALERT_NOTIFICATION`)
   - `IMPORT_CLOUD_INSTANCES` (cloud instance import)
   - `UPDATE_GROUP_SETTINGS` (consumer group settings write path)
   
   Without an entry each of these renders in the audit list and the 
risk-insights table through the fallback: a grey `other` tag with an 
auto-title-cased English label and **no translation key** — so the Chinese 
audit page shows raw English like "Create Alert Silence", and the operation 
never lands in its category color. The notification-delivery codes in 
particular are the ones an operator investigates when a DingTalk message never 
arrived.
   
   ## Root cause / Fix
   
   The registry and the `audit.op.*` / `audit.res.*` translations were written 
before those server features landed and were never extended. Add the ten 
operation entries (silences and notification delivery under `alerts`, cloud 
import under `instance`, group settings under `metadata`), the two resource 
entries, and the matching zh/en translations.
   
   ## Tests
   
   - New case in `auditPresentation.test.ts` asserting every listed code 
resolves to a registered category and label key (plus the two new resources). 
Fails on the pre-fix code (all fell back to `other`).
   - `npx vitest run` over `auditPresentation`, `auditRiskInsights`, 
`AuditPage` tests → 33/33 passed; `npx tsc --noEmit -p tsconfig.app.json` 
clean; eslint on touched files clean.
   
   ## Risk
   
   Low: additive registry/translation entries; the fallback path is unchanged 
for genuinely unknown codes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to