lizhimins commented on PR #5731: URL: https://github.com/apache/rocketmq-dashboard/pull/5731#issuecomment-6094438414
> Thanks — the notification-delivery half of this is real and still missing: `NotificationOutboxService` > records `DELIVER_ALERT_NOTIFICATION` (:392), `RETRY_ALERT_NOTIFICATION` / `FAIL_ALERT_NOTIFICATION` > (:539) and `RETRY_ALERT_NOTIFICATION_MANUALLY` (:258), and none of them resolve to a category or a > translation key on the current base. The other half has landed since you branched: #5538 already added > `CREATE_ALERT_SILENCE`, `DELETE_ALERT_SILENCE`, `IMPORT_CLOUD_INSTANCES` and `UPDATE_GROUP_SETTINGS` > (`auditPresentation.ts:121-136`, `translations.ts:1553-1556`), plus `audit.res.ALERT_SILENCE`. > Git merges your branch cleanly, but the result contains duplicate object keys — `CREATE_ALERT_SILENCE` > at both :122 and :134, `UPDATE_GROUP_SETTINGS` at :58 (cyan) and :159 (purple), and four duplicate > `audit.*` translation keys with *different* zh copy (`创建告警静默` vs `创建静默窗口`, etc.). That trips > `no-dupe-keys` and would silently override the copy that already shipped. Please rebase, drop the > entries that have landed, keep the four notification codes plus `ALERT_NOTIFICATION`, and narrow the > new test to those (four of its assertions currently pass on the base without your patch, so they no > longer demonstrate red-first). Also drop the unrelated `ai.list.archiveFailed` reformat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
