zjncs opened a new pull request, #5751:
URL: https://github.com/apache/rocketmq-dashboard/pull/5751
### What
`MetricsSourceSettings` — the resolved connection settings every
Prometheus-compatible backend is queried through — had no test. This adds
`MetricsSourceSettingsTest` with 3 tests.
### What is pinned
- **the builder defaults are the operational budget**: 3s connect / 10s
read, PROMETHEUS backend, no auth;
- every supplied value overrides its default;
- **the query path is the backend's own, delegated by type** — a Victoria
Metrics source must not be queried on the Prometheus path.
### Verification
- New tests on unmodified code: **3/3 green**, checkstyle clean (`mvn test
-Dtest=MetricsSourceSettingsTest`).
- Discriminating mutations on `MetricsSourceSettings`, build result verified
red each time:
1. the connect timeout default relaxed from 3s to 30s — red;
2. the query path hardcoded to the Prometheus path instead of delegated —
red;
3. the default auth type changed from none to basic — red.
- Restored: 3/3 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
