zjncs commented on PR #5606: URL: https://github.com/apache/rocketmq-dashboard/pull/5606#issuecomment-6076366599
@lizhimins Thank you for the thorough review — all four points are addressed in the re-submission #5775 (GitHub won't let the author reopen a maintainer-closed PR, and a closed PR's base can't be changed, so a new PR was the only path): 1. Both test methods renamed to end with `Test` (`fullDataSourceListIsCachedAsDocumentedTest` / `parameterizedDataSourceSearchMustNotAccumulatePermanentCacheEntriesTest`); 2. Trailing newlines restored on both files; 3. The credential-exposure framing is dropped everywhere (comment, test javadoc, and PR description) — you're right that `DataSourceVO` carries no credential fields; the unbounded-heap argument stands on its own; 4. `@Configuration`/`@Bean` moved to imports, matching `SettingsServiceCachingTest`. Rebased onto `rocketmq-studio` (c99b9ad5) where the finding still reproduces; verification rerun there: 3/3 green including the sibling convention test, and the mutation check (restoring only the `@Cacheable`) fails with `Tests run: 2, Failures: 1`. Sorry for the stale-`master` targeting — we've fixed our process to always base dashboard PRs on `rocketmq-studio` going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
