zjncs commented on PR #5606: URL: https://github.com/apache/rocketmq-dashboard/pull/5606#issuecomment-6077855617
Thank you for the thorough review — all four points addressed in 9f6f38c: 1. **Test method names** now end with `Test` (`fullDataSourceListIsCachedAsDocumentedTest` / `parameterizedDataSourceSearchMustNotAccumulatePermanentCacheEntriesTest`). 2. **Trailing newlines** — verified present in both committed files. 3. **Severity corrected**: the credential-exposure framing is removed from both the product comment and the test javadoc. You're right that `DataSourceVO` carries no `authType`/`username`/`password`/`bearerToken` (those live on `DataSourceTestDTO`, which is never cached). The argument stands on the unbounded-heap side alone, and the PR description claim is withdrawn. 4. **`@Configuration`/`@Bean`** now imported rather than fully qualified. **Retargeted to `rocketmq-studio`** as requested. Verification: `mvn test -Dtest=SettingsServiceDataSourceCacheBoundTest` green with checkstyle clean — the control test proves the full-list cache still works (repository hit once), the bound test proves 50 distinct searches leave zero permanent entries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
