iloveeyjafjalla opened a new pull request, #6267: URL: https://github.com/apache/rocketmq-dashboard/pull/6267
### Which Issue(s) This PR Fixes The accompanying bug report will be linked immediately after this PR is created. ### Brief Description An instance named `1` can be selected normally for a data source, but the table and CSV display another instance's name if its numeric ID is `1` and it appears earlier in the instance list. The edit modal still shows the selected name correctly. Resolve exact instance names before falling back to legacy numeric IDs in the shared display/export formatter. Preserve legacy-only bindings, unknown names, global sources and binding order. Add component regressions for the table/edit selection, the actual CSV export action and those compatibility cases. ### How Did You Test This Change? Baseline: `rocketmq-studio@5e4c39b053c35a5598cc79ff331b8a54e649d7b1`. Windows 11, Node 24.15.0, npm 11.12.1; separate LF worktree with the existing `npm ci` dependencies shared through a local junction. - New regressions against unchanged production code: 2 expected failures (table and CSV show `apache-main` instead of `1`), 1 compatibility control passed. - `npm test -- --maxWorkers=1 src/pages/settings/__tests__/DataSourceTab.test.tsx src/api/settings.test.ts`: 19/19 passed. - `npm run lint`: passed, 0 errors and 10 warnings in untouched files. Targeted ESLint, Prettier and `git diff --check` passed. - `npm run build`: passed, including the license gate (133 components, 140 legal files). - `npm test -- --maxWorkers=4`: all 153 files and 1520/1520 tests passed (619.65 seconds). The automated reproduction renders the real DataSourceTab and keeps the real CSV builder, supplying controlled responses at the existing API/service boundaries. Numeric names are accepted by the cloud-instance form and data-source options use names as values. No live cloud service, broker, database or deployment was tested; Java/Go checks were not run for this frontend-only change. AI assistance: OpenAI Codex helped investigate, implement and verify the change. A separate automated agent reviewed the source path, actual diff and regression evidence; no human or maintainer approval is claimed. ### Checklist - [x] One coherent fix and its tests - [x] Conventional Commit subject - [x] Regression tests added, names end in `Test` - [x] New UI translations: N/A, no UI text added - [ ] Java architecture/integration tests: not run, no backend change - [x] Existing ASF headers retained; no new source file - [x] Documentation: N/A, restores correct existing labels -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
