The GitHub Actions job "Run Integration Tests" on 
rocketmq.git/fix/lite-subscription-offline-empty-list has failed.
Run started by GitHub user zjncs (triggered by zjncs).

Head commit for run:
ce9c4bca2cf8b05b310f333a9c91a9b1dbf4b477 / zjncs <[email protected]>
fix(proxy): offline all lite subscriptions and guard empty subscription list

offlineClientLiteSubscription only took subscriptions(0) to build the
COMPLETE_REMOVE LiteSubscriptionDTO, so a lite consumer subscribing to
multiple topics left stale subscriptions on the broker for every topic
after the first one. When the subscription list was empty,
getSubscriptions(0) threw IndexOutOfBoundsException which was swallowed
by the catch block, so the cleanup was silently skipped entirely and
the stale lite subscription could trigger LITE_SUBSCRIPTION_QUOTA_EXCEEDED
on the next connect.

Iterate over all subscription entries and send one COMPLETE_REMOVE per
topic; an empty list now simply sends nothing.

Report URL: https://github.com/apache/rocketmq/actions/runs/34573479648

With regards,
GitHub Actions via GitBox

Reply via email to