coder999o opened a new pull request, #6303: URL: https://github.com/apache/rocketmq-dashboard/pull/6303
## What is the purpose of the change Client connection diagnostics use `|` to join and later split identity fields. Pipes inside Client IDs or resource names can make different records appear identical and corrupt the evidence for actual duplicates. Fixes #6302 ## Brief changelog - Encode the normalized connection identity as a JSON array and decode it without losing field boundaries. - Preserve duplicate counts, normalization and severity; diagnostic IDs remain opaque table keys. - Add regressions for distinct tuples that previously collided and complete evidence for actual duplicates. ## Verifying this change - `cd web && npm test -- src/utils/clientConnectionDiagnostics.test.ts src/pages/cluster/__tests__/ClientsPage.test.tsx src/pages/cluster/__tests__/clientsSearch.test.ts` (36 passed). - `cd web && npx tsc -p tsconfig.app.json --noEmit --composite false --incremental false` (passed). - `cd web && npx eslint src/utils/clientConnectionDiagnostics.ts src/utils/clientConnectionDiagnostics.test.ts` (passed). - `cd web && npx prettier --check src/utils/clientConnectionDiagnostics.ts src/utils/clientConnectionDiagnostics.test.ts` (passed). - `git diff --check` (passed). Both new regressions failed before the fix and passed afterward. The tests used frontend fixtures and mocked APIs; the full frontend suite and live Broker integration were not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
