lizhimins commented on PR #6303: URL: https://github.com/apache/rocketmq-dashboard/pull/6303#issuecomment-6120497162
Thanks — this is merged, as part of [`7df91fde3`](https://github.com/apache/rocketmq-dashboard/commit/7df91fde36241973ee604b763e5edfae5f26c40f) on `rocketmq-studio`. Your change went in together with #6064 and #6207 — all yours, all in the same area — so we folded them into a single commit instead of landing several near-identical entries for the same subsystem. Nothing was dropped. The commit message calls this one out explicitly: > #6303 `clientConnectionDiagnostics.ts:156-162` built the duplicate-detection identity with `[type, clientId, groupOrTopic, address].join('|')` and `:267` decoded it with `split('|')`, but `|` is a legal topic and group character — the kernel's `TopicValidator` sets `VALID_CHAR_BIT_MAP['|'] = true` — and a client `instanceName` is arbitrary, so two distinct quadruples could collapse into one `identityCounts` key and raise a false `EXACT_DUPLICATE_CONNECTION`, while the `clientId`, `resource` and `evidence: address=` reported to the operator were shifted out of their fields → both sides switch to `JSON.stringify` / `JSON.parse` at the same two points, leaving the duplicate counts, `normalizeText` normalisation, `info` severity, evidence shape and the opaque table `id` unchanged; `connectionIdentity` has exactly one call site (`:242`) and `connectionsByClient` keys off `normalizeText(clientId)`, so nothing else needed to move. Closing as folded, not rejected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
