123123213weqw opened a new pull request, #6384:
URL: https://github.com/apache/rocketmq-dashboard/pull/6384

   @lizhimins Supersedes #5761 (GitHub refuses to reopen maintainer-closed PRs, 
hence the fresh one) — same fix, with both review asks applied on top, and the 
branch merged onto the current `rocketmq-studio`.
   
   ## What
   
   `AiRunService`'s unowned-stop path re-reads the run row before writing 
anything: a stop that reaches the service after the worker already finalised 
the run must not write a second terminal over it — that duplicated the 
`run_status` event and flipped a run the user watched finish to `STOPPED`.
   
   ## Review asks from #5761, applied
   
   - The regression test carries the `Test` suffix per repo convention 
(`aStopThatLosesTheFinalisationRaceMustNotWriteASecondTerminalTest`).
   - The unowned branch no longer re-reads the row a second time after 
`terminate` — it falls through to the method's own final return, which performs 
the same re-read.
   
   `AiRunServiceTest` is green on this branch. As you noted in #5761, this and 
#5760 cover the two sides of the same corruption; this one is ready 
independently.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to