123123213weqw opened a new pull request, #6387: URL: https://github.com/apache/rocketmq-dashboard/pull/6387
@lizhimins Supersedes #5771 (GitHub refuses to reopen maintainer-closed PRs, hence the fresh one) — same ordering fix, with the review asks applied, and the branch merged onto the current `rocketmq-studio`. ## What The dashboard overview is the one view that walks `clusterAddrTable` in raw map order; the cluster list (`RealClusterProvider.java:133`) sorts its walk by name. This sorts the overview's per-cluster pass too, so the two views list the same clusters in the same order. ## Review asks from #5771, applied - Test renamed to `dashboardClusterOverviewShouldOrderClustersByNameTest` per repo convention. - Rationale softened: a `HashMap` iterates deterministically for a given key set, so the overview does not reorder itself between polls — the value is agreeing with the cluster list, as the updated comment now says. `RocketMQDashboardProviderTest` is green on this branch. Ready to merge together with the #5770 successor so the cluster list and the overview agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
