pilichoumao opened a new pull request, #6639:
URL: https://github.com/apache/rocketmq-dashboard/pull/6639

   ### Which Issue(s) This PR Fixes
   
   Fixes #6638.
   
   ### Brief Description
   
   The DLQ regression sends three messages, but code=200 and an increasing 
consumer log count can still accompany a PARTIAL result or resending only two 
messages. The script then prints PASS even though the resend did not complete 
this regression.
   
   Require SUCCESS, matched=3, resent=3, failed=0, a complete scan and zero 
failed queues before checking reconsumption. Use an explicit failure instead of 
assert so the verdict remains enforced with optimized Python. Preserve the 
existing consumer check and EXIT cleanup.
   
   Add dependency-free unittest coverage that runs the committed shell script 
and its Python client with task-local HTTP/SSH fixtures. It checks success, 
partial resend, incomplete scan, short SUCCESS, missing data, absent consumer 
progress and optimized Python, including container and group-before-topic 
cleanup.
   
   ### How Did You Test This Change?
   
   - `python3 -m unittest discover -s 
.claude/skills/regression-rocketmq/scripts/tests -v`: **7 passed** on macOS and 
Ubuntu 24.04 ECS (Python 3.12.3, Bash 5.2.21).
   - The same tests against the original script: **5 failed, 2 controls 
passed**, on both environments; failures were false success verdicts, not 
fixture errors.
   - `bash -n .claude/skills/regression-rocketmq/scripts/dlq_check.sh` and `git 
diff --check`: passed. ECS final script/test hashes match the local sources.
   
   Fixtures replace HTTP, SSH, scp and waits; no real Broker, Docker or 
Kubernetes end-to-end success is claimed. Existing CI does not automatically 
discover these Python tests; the command above is the standalone check.
   
   ### Checklist
   
   - [x] One coherent change; Conventional Commit subject
   - [x] Regression tests added and valid success/failure controls preserved
   - [x] New test file carries an ASF license header
   - [x] No application API, dependency or UI-text changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to