messere1 opened a new pull request, #11436:
URL: https://github.com/apache/rocketmq/pull/11436
<!-- Please make sure the target branch is right. In most case, the target
branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #11435
### Brief Description
`PopLiteMessageProcessor#preCheck` logs `The parentTopic {} not exist,
consumer: {} ` with two placeholders but only one argument, so the consumer
group is never rendered — the log line ends with a literal `consumer: {}`. Pass
`PopLiteMessageRequestHeader#getConsumerGroup()` as the missing argument so
operators can tell which consumers are affected when a parent topic is deleted
or misconfigured.
### How Did You Test This Change?
Red/green in `PopLiteMessageProcessorTest`:
- `testPreCheckLogTopicNotExistContainsConsumer` — new test: calls
`preCheck` with a topic that has no `TopicConfig` and `consumerGroup =
"groupA"`, captures the formatted log event via a `ListAppender` on the
`RocketmqPopLite` logger, and asserts the message contains `consumer: groupA`.
- RED (pre-fix): `java.lang.AssertionError` — the formatted message is
`The parentTopic nonExistTopic not exist, consumer: {}`.
- GREEN (post-fix): the message contains `consumer: groupA`.
Full runs:
- `mvn -pl broker test -Dtest='PopLiteMessageProcessorTest'` → Tests run:
24, Failures: 0, Errors: 0 (23 pre-existing + 1 new).
- `mvn -pl broker checkstyle:check` (project ruleset
`style/rmq_checkstyle.xml`) → BUILD SUCCESS.
Note: the build stops after tests at `jacoco:0.8.5:report` with "Unsupported
class file major version 61" — this is environmental (JaCoCo 0.8.5 vs Java 17
bytecode) and reproduces on a clean develop; the test phase itself passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
