iloveeyjafjalla opened a new pull request, #7035: URL: https://github.com/apache/rocketmq-dashboard/pull/7035
Fixes #7034 ## The defect `localizeDeliveryError` maps four failure shapes; the two messages `NotificationOutboxService` raises itself — `SMTP is not configured` and `No valid email recipients` — fall through to raw English in the delivery table and detail dialog, although they are the failures an operator hits while setting the email channel up. ## The fix Two exact-match entries in the existing mapping, each with its own copy (`deliveries.errSmtpNotConfigured`, `deliveries.errInvalidEmailRecipients`) so the table says what to fix; unmapped failures still pass through unchanged, which the new test pins as well. ## Tests Red before the change (`expected 'SMTP is not configured' to be 'key:…'`), green after: ``` Tests 9 passed (9) (deliveryResult.test.ts + NotificationDeliveriesPage.test.tsx) tsc -b exit 0 eslint exit 0 prettier --check All matched files use Prettier code style! ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
