The GitHub Actions job "Run Integration Tests" on 
rocketmq.git/codex/proxy-remoting-timer-shutdown has succeeded.
Run started by GitHub user iloveeyjafjalla (triggered by iloveeyjafjalla).

Head commit for run:
4a45d9ef8048e5c83d834eaaa8f354527c426f98 / iloveeyjafjalla <[email protected]>
fix(proxy): stop the expired-request timer when the remoting server shuts down

The constructor schedules cleanExpireRequest on a single-thread
ScheduledExecutorService created with ThreadFactoryBuilder - whose threads are 
not
daemons - and shutdown() stops the eight remoting executors but not that one. A
stopped server therefore keeps a live thread running the 100ms cleanup task, and
the non-daemon thread keeps the JVM alive after the context has closed. This is 
the
same shape as the pop-consume service that #11428 stopped on the push consumer.

Stop it with the rest, and pin the shutdown contract so a new executor cannot be
started without also being stopped.

Report URL: https://github.com/apache/rocketmq/actions/runs/39377672244

With regards,
GitHub Actions via GitBox

Reply via email to