hickey-ai opened a new pull request, #11463:
URL: https://github.com/apache/rocketmq/pull/11463

   ### Which Issue(s) This PR Fixes
   
   Fixes #11460
   
   ### Brief Description
   
   Convert NumberFormatException from the two numeric checkpoint header fields 
to IOException with the file path and original cause. This lets the existing 
.bak recovery work for empty, truncated or malformed headers. The catch is 
limited to header parsing; serializer exceptions, empty-state behavior and 
normal primary precedence are not changed.
   
   This is distinct from #11032, which handles persisting/reading empty 
checkpoint state.
   
   ### How Did You Test This Change?
   
   - The original implementation reproduced an unchecked NumberFormatException 
in the native common test. Surefire stopped after the first failure (2 
reported: 1 error, 1 skipped); all six new methods were not claimed executed 
before the fix.
   - Independent Java 8/Maven 3.6.3 run: `mvn -B -pl remoting -am 
-Dtest=CheckpointFileHeaderTest,CheckpointFileTest 
-Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false test`.
   - All 9 tests passed (6 new common header tests and 3 existing remoting 
checkpoint tests), 0 failures/errors/skips. Checkstyle and SpotBugs passed.
   - Full published Git tree equals the tested local commit tree.
   
   No live broker or HA failover test is claimed.
   
   AI assistance: OpenAI Codex was used for investigation, implementation and 
tests; commits include tooling provenance.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to